Conversation
cnathe
approved these changes
Apr 28, 2026
| public void testAssayMultiFileImportForMVTC() throws Exception | ||
| { | ||
| Assume.assumeTrue("Multi-choice text fields are only supported on PostgreSQL", WebTestHelper.getDatabaseType() == WebTestHelper.DatabaseType.PostgreSQL); | ||
| OptionalFeatureHelper.enableOptionalFeature(getCurrentTest().createDefaultConnection(), "multiChoiceDataType"); |
Contributor
There was a problem hiding this comment.
minor: looks like this test and some others in the various PRs here have an unused import of OptionalFeatureHelper that can be removed.
| @@ -189,7 +189,6 @@ public void testDatasets() | |||
| public void testDatasetWithMultiChoice() | |||
| { | |||
| Assume.assumeTrue("Multi-choice text fields are only supported on PostgreSQL", WebTestHelper.getDatabaseType() == WebTestHelper.DatabaseType.PostgreSQL); | |||
Contributor
There was a problem hiding this comment.
unrelated to this PR, but the tests that have this check, do they just fail in MSSQL runs? seems like we'd instead just want to return if not postgres so that the test "passes" and doesn't cause noise on TC.
Contributor
Author
There was a problem hiding this comment.
Looking at the documentation, a failed assume would halt and ignore the rest of the test, which sounds correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Remove
multiChoiceDataTypeexperimental flag from code and testsRelated Pull Requests
Changes